Skip to content

Update to jigsaw-1.1.1.x - #32

Merged
dengwirda merged 39 commits into
masterfrom
dev
Nov 16, 2026
Merged

dengwirda merged 39 commits into
masterfrom
dev

Conversation

@dengwirda

Copy link
Copy Markdown
Owner

jigsaw-python changes:

  • Update bindings to support jigsaw-1.1.1.x back-end.
  • Support for NetCDF-based binary file I/O, by simply replacing any *.msh file argument with a *.nc extension.
  • Many bug-fixes and improvements, as a result of a Codex-based audit.

Major changes (jigsaw):

  • Support for NetCDF-based binary file I/O for all cmd-line tools.

Minor changes (jigsaw):

  • Various bug-fixes and updates as a result of a Codex-based audit.

dengwirda and others added 30 commits November 13, 2026 08:24
c13d9bc Remove -ffinite-math-only from build to help clang
a844f00 A simple update to optimisation re-ordering
7bfa98f Include absolute quality in reordering metric
6cf2cc8 Fix pass-by-value issue
36a612d Refactor I/O and add initial NetCDF support
edf84a6 Add support for typed NetCDF attribute reads
7347e03 Add support for typed NetCDF reads
6e9b09e Add initial read support for NetCDF-based I/O
4baef99 Remove unneeded template arguments from user params
aa140ff Finish refactor of user params and associated I/O
4052999 Refactor of user params and associated I/O
648bbae Correct filename in h(x) reader
ae38005 Add extra error checks to binary readers
93a2357 Improve treatment of corner cases in readers
b471a7d Update coord treatment in readers
f16bfee Simplify read pathways via consumer pattern
a338575 Add codex-based fixes and updates
2553b3b Update jigsaw version string
f7dfe82 Update jigsaw version string
33d9887 Balance truncation and round-off in finite-difference epsilon
b478af0 Include all adaptive predicates in R^4
93c1b6a Update cmake workflows
a790bf9 Ensure rDEL^k objects are correctly clear'd
2816bd0 Correct issues with *.jig output
77bf7d2 Fix quad-cell indexing issue on data write
2425c17 Fix typo in *.jig summary
c4bbdc3 Ensure ellipsoid radii are properly initialised
e5e7af0 Create .gitignore
fae5131 Initial JIGSAW
9c152f9 Initial JIGSAW
07f0c87 Add check for *.msh files with empty sections
420a6bc Update ellipsoidal surface projection
a987ed8 Update ellipsoidal surface projection
138e36a Update ellipsoidal intersection predicates
0d8c855 Return index from ellipsoidal inside test
a2fda87 Update small range treatment in sorting algorithms
5650bd7 Fix corner-cases in sorting algorithms
07b8790 Ensure heap resize methods update internal keys
2d86c06 Fix corner-cases in priority queues
fc88d41 Forbid copy and/or move construction of pools
8050f84 Fix corner-cases in linked-list containers
1b2d29a Correct remove-tail method in doubly-linked list
a5261b0 Update allocators to handle rvalue types
63d2ecf Ensure pool re-alloc supports full de-alloc
bbe741c Ensure byte-rounded alloc sizes in pools
c3218cf Fix const-cast issues in array iterators
d4fe604 Correct fixed array reverse iterator endpoint
7c29574 Fix push-on-block-growth issue in block'd array
8ab1718 Fix finite-difference bounds in gradient optimiser
9286756 Ensure counters correctly accumulate in mesh zipping
d2264ee Ensure exact mass used in ODT/CVT updates
2ae2395 Skip zero finite-difference steps in gradient optimiser
d6f3e67 Ensure weight optimisation uses momentum updates
8be6fb7 Ensure optimisation init. matches in serial and parallel
496fea0 Add missing timer epoch
6cd9b4e Correct corner-case in progress output
840c980 Ensure all vertices in tetrahedrons are visited
4bf4c91 Decline topol. refinement if no candidates
5a1f837 Ensure correct list size in rDEL^k init
d9e8d80 Fix duplicate scan in hash-twice table
141d1e6 Fix re-hashing if reducing size
f5db448 Fix re-hashing if reducing size
87b6381 Fix re-hashing if reducing size
cb40b72 Ensure mesh links can be rebuilt cleanly
1d4f6df Ensure reinsertion of existing cell correctness
2ca0b09 Ensure pointer list correctly emptied
974bfa7 Ensure symmetry of AABB distance evaluations
ac9f799 Ensure h(x) coord. saved in full precision
d8e93f0 Fix periodic gradient limiter case
22e8ca8 Fix scaling for ellipsoid h(x) types
9c0e095 Fix corner-cases in interpolants
ed3fa4e Fix pole correction indexing
bb98da1 Improve convergence of tetrahedral gradient limiter
d0151a3 Improve predicate robustness
6598aa1 Fix corner-case in 3d gradient limiter
070ba3b Improve robustness of quadratic root solver
2138985 Improve robustness of quality metrics
40d19b2 Fix weighted predicate tolerances
9e47448 Fix weighted predicate tolerances
b671302 Fix weighted predicate tolerances
54c59d4 Improve robustness of IA-FLOAT::MID
78022e0 Remove spurious weight from INBALL2D_i
ffb2c3c Update FMAF typedef
7333cef Bugfix: multi-precision expansion + predicates
30e53e9 Ensure symmetric h(x) gradient limiter
a0a50e0 Fix potential out-of-range indexing
fbb031e Fix under/overflow issues in sign comparisons
f4f79f0 Ensure SEED vertices are free'd
e64fc7b Ensure symmetric h(x) gradient limiter
00a0f49 Exclude weights from Laguerre flip tolerance
cc3ce7d Ensure consistent free-list handling in triangulation

git-subtree-dir: external/jigsaw
git-subtree-split: c13d9bc74bf07da36acc6eb92c0dcfb65c13e89b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b17a889 Update build and CI workflow
720e48a Update unit test conventions and workflows
32c5454 Fix issues with format of INIT_NEAR keyword in jig_t

git-subtree-dir: external/jigsaw
git-subtree-split: b17a88924b8186a14eda24a652bec89221dcdf7d
56ad4d0 Update CI workflow and add timeout limits
3d6f94c Remove interval filter from floating-point predicates

git-subtree-dir: external/jigsaw
git-subtree-split: 56ad4d0e6d5217930f04f0d96225a756a6ea90c0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3777fe7f Ensure *.nc writers use lowercase title attribute

git-subtree-dir: external/jigsaw
git-subtree-split: 3777fe7f00815295a94065cdcaca27bcb3c2106e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dengwirda and others added 8 commits November 15, 2026 14:06
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dengwirda

dengwirda commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner Author

@xylar if you're keen to try the *.nc option, the plan is that it should only require a change to file extensions, e.g.:

opts.jcfg_file = "opts.jig"
opts.geom_file = "geom.msh"  # usual ascii
opts.hfun_file = "spac.nc"
opts.mesh_file = "mesh.nc"   # netcdf version of *.msh
# etc, etc...
jigsawpy.savemsh(opts.hfun_file, spac)  # will save to *.nc version of *.msh
# etc, etc...
jigsawpy.cmd.jigsaw(opts, mesh)  # should "just work"...

I'm conscious of potential trouble handling NetCDF library dependencies. I've had success installing into conda envs on a few HPC systems, but let me know...

@xylar

xylar commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Thanks @dengwirda! I tried this on my laptop and a few HPC machines and things are working fine with conda-forge's lbnetcdf linked in. It does look the NetCDF meshes are identical to the .msh files produced by this code so that will save us a conversion step.

@dengwirda

Copy link
Copy Markdown
Owner Author

@xylar great that netcdf is behaving itself.
I'll keep this open for a little longer while I finalise testing, but hopefully this'll merge in as v1.1.1 soon.

@dengwirda
dengwirda merged commit 043e47a into master Nov 16, 2026
6 checks passed
@dengwirda
dengwirda deleted the dev branch November 17, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants